coopgo-platform
/
gorush
7
0
Fork 0
Code Issues Pull Requests Projects Releases 1 Wiki Activity

Check status of response before retry send push (#507)

This commit is contained in:
Romanenko Alexey 2020-05-06 18:37:06 +07:00 committed by GitHub
parent c8ce081803
commit 20a9d18ce6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gorush/notification_apns.go
View File

@ -389,7 +389,11 @@ Retry:
} }
StatStorage.AddIosError(1) StatStorage.AddIosError(1)
// We should retry only "retryable" statuses. More info about response:
// https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server/handling_notification_responses_from_apns
if res.StatusCode >= http.StatusInternalServerError {
newTokens = append(newTokens, token) newTokens = append(newTokens, token)
}
isError = true isError = true
} }

7
gorush/notification_fcm.go
View File

@ -164,8 +164,13 @@ Retry:
} }
if result.Error != nil { if result.Error != nil {
isError = true // We should retry only "retryable" statuses. More info about response:
// https://firebase.google.com/docs/cloud-messaging/http-server-ref#downstream-http-messages-plain-text
if !result.Unregistered() {
newTokens = append(newTokens, to) newTokens = append(newTokens, to)
}
isError = true
LogPush(FailedPush, to, req, result.Error) LogPush(FailedPush, to, req, result.Error)
if PushConf.Core.Sync { if PushConf.Core.Sync {
req.AddLog(getLogPushEntry(FailedPush, to, req, result.Error)) req.AddLog(getLogPushEntry(FailedPush, to, req, result.Error))