Check status of response before retry send push (#507)

gorush/notification_apns.go

@@ -389,7 +389,11 @@ Retry:
 				}
 
 				StatStorage.AddIosError(1)
+				// We should retry only "retryable" statuses. More info about response:
+				// https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server/handling_notification_responses_from_apns
+				if res.StatusCode >= http.StatusInternalServerError {
 					newTokens = append(newTokens, token)
+				}
 				isError = true
 			}
 

gorush/notification_fcm.go

@@ -164,8 +164,13 @@ Retry:
 		}
 
 		if result.Error != nil {
-			isError = true
+			// We should retry only "retryable" statuses. More info about response:
+			// https://firebase.google.com/docs/cloud-messaging/http-server-ref#downstream-http-messages-plain-text
+			if !result.Unregistered() {
 				newTokens = append(newTokens, to)
+			}
+			isError = true
+
 			LogPush(FailedPush, to, req, result.Error)
 			if PushConf.Core.Sync {
 				req.AddLog(getLogPushEntry(FailedPush, to, req, result.Error))