fix: check response is nil or not (#532)

This commit is contained in:
Bo-Yi Wu 2020-07-14 22:52:39 +08:00 committed by GitHub
parent 300fdc2f22
commit 7c7e740fec
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions

View File

@ -392,7 +392,7 @@ Retry:
// send ios notification // send ios notification
res, err := client.Push(notification) res, err := client.Push(notification)
if err != nil || res.StatusCode != 200 { if err != nil || (res != nil && res.StatusCode != http.StatusOK) {
if err == nil { if err == nil {
// error message: // error message:
// ref: https://github.com/sideshow/apns2/blob/master/response.go#L14-L65 // ref: https://github.com/sideshow/apns2/blob/master/response.go#L14-L65
@ -415,13 +415,13 @@ Retry:
StatStorage.AddIosError(1) StatStorage.AddIosError(1)
// We should retry only "retryable" statuses. More info about response: // We should retry only "retryable" statuses. More info about response:
// https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server/handling_notification_responses_from_apns // https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server/handling_notification_responses_from_apns
if res.StatusCode >= http.StatusInternalServerError { if res != nil && res.StatusCode >= http.StatusInternalServerError {
newTokens = append(newTokens, token) newTokens = append(newTokens, token)
} }
isError = true isError = true
} }
if res.Sent() && !isError { if res != nil && res.Sent() && !isError {
LogPush(SucceededPush, token, req, nil) LogPush(SucceededPush, token, req, nil)
StatStorage.AddIosSuccess(1) StatStorage.AddIosSuccess(1)
} }