integrate memory engine.

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
This commit is contained in:
Bo-Yi Wu 2016-05-02 17:03:08 +08:00
parent 17c4ca4b2e
commit 8df5c63860
8 changed files with 203 additions and 369 deletions

View File

@ -20,8 +20,8 @@ var (
LogAccess *logrus.Logger LogAccess *logrus.Logger
// LogError is log server error log // LogError is log server error log
LogError *logrus.Logger LogError *logrus.Logger
// RushStatus is notification status
RushStatus StatusApp
// RedisClient is global variable for redis // RedisClient is global variable for redis
RedisClient *redis.Client RedisClient *redis.Client
// StatStorage implements the storage interface
StatStorage Storage
) )

View File

@ -199,7 +199,7 @@ func queueNotification(req RequestPush) int {
count += len(notification.Tokens) count += len(notification.Tokens)
} }
addTotalCount(int64(count)) StatStorage.AddTotalCount(int64(count))
return count return count
} }
@ -315,7 +315,7 @@ func PushToIOS(req PushNotification) bool {
// apns server error // apns server error
LogPush(FailedPush, token, req, err) LogPush(FailedPush, token, req, err)
isError = true isError = true
addIosError(1) StatStorage.AddIosError(1)
continue continue
} }
@ -323,13 +323,13 @@ func PushToIOS(req PushNotification) bool {
// error message: // error message:
// ref: https://github.com/sideshow/apns2/blob/master/response.go#L14-L65 // ref: https://github.com/sideshow/apns2/blob/master/response.go#L14-L65
LogPush(FailedPush, token, req, errors.New(res.Reason)) LogPush(FailedPush, token, req, errors.New(res.Reason))
addIosError(1) StatStorage.AddIosError(1)
continue continue
} }
if res.Sent() { if res.Sent() {
LogPush(SucceededPush, token, req, nil) LogPush(SucceededPush, token, req, nil)
addIosSuccess(1) StatStorage.AddIosSuccess(1)
} }
} }
@ -410,8 +410,8 @@ func PushToAndroid(req PushNotification) bool {
} }
LogAccess.Debug(fmt.Sprintf("Android Success count: %d, Failure count: %d", res.Success, res.Failure)) LogAccess.Debug(fmt.Sprintf("Android Success count: %d, Failure count: %d", res.Success, res.Failure))
addAndroidSuccess(int64(res.Success)) StatStorage.AddAndroidSuccess(int64(res.Success))
addAndroidError(int64(res.Failure)) StatStorage.AddAndroidError(int64(res.Failure))
for k, result := range res.Results { for k, result := range res.Results {
if result.Error != "" { if result.Error != "" {

View File

@ -222,6 +222,7 @@ func TestPushToIOS(t *testing.T) {
PushConf.Ios.Enabled = true PushConf.Ios.Enabled = true
PushConf.Ios.PemKeyPath = "../certificate/certificate-valid.pem" PushConf.Ios.PemKeyPath = "../certificate/certificate-valid.pem"
InitAPNSClient() InitAPNSClient()
InitAppStatus()
req := PushNotification{ req := PushNotification{
Tokens: []string{"11aa01229f15f0f0c52029d8cf8cd0aeaf2365fe4cebc4af26cd6d76b7919ef7"}, Tokens: []string{"11aa01229f15f0f0c52029d8cf8cd0aeaf2365fe4cebc4af26cd6d76b7919ef7"},

View File

@ -1,12 +1,9 @@
package gorush package gorush
import ( import (
"github.com/asdine/storm" "github.com/appleboy/gorush/gorush/storage/memory"
"github.com/gin-gonic/gin" "github.com/gin-gonic/gin"
"gopkg.in/redis.v3"
"net/http" "net/http"
"strconv"
"sync/atomic"
) )
// StatusApp is app status structure // StatusApp is app status structure
@ -30,222 +27,18 @@ type IosStatus struct {
PushError int64 `json:"push_error"` PushError int64 `json:"push_error"`
} }
func initApp() {
RushStatus.TotalCount = 0
RushStatus.Ios.PushSuccess = 0
RushStatus.Ios.PushError = 0
RushStatus.Android.PushSuccess = 0
RushStatus.Android.PushError = 0
}
func initRedis() error {
RedisClient = redis.NewClient(&redis.Options{
Addr: PushConf.Stat.Redis.Addr,
Password: PushConf.Stat.Redis.Password,
DB: PushConf.Stat.Redis.DB,
})
_, err := RedisClient.Ping().Result()
if err != nil {
// redis server error
LogError.Error("Can't connect redis server: " + err.Error())
return err
}
RushStatus.TotalCount = getTotalCount()
RushStatus.Ios.PushSuccess = getIosSuccess()
RushStatus.Ios.PushError = getIosError()
RushStatus.Android.PushSuccess = getAndroidSuccess()
RushStatus.Android.PushError = getAndroidError()
return nil
}
func initBoltDB() {
RushStatus.TotalCount = getTotalCount()
RushStatus.Ios.PushSuccess = getIosSuccess()
RushStatus.Ios.PushError = getIosError()
RushStatus.Android.PushSuccess = getAndroidSuccess()
RushStatus.Android.PushError = getAndroidError()
}
// InitAppStatus for initialize app status // InitAppStatus for initialize app status
func InitAppStatus() { func InitAppStatus() {
switch PushConf.Stat.Engine { switch PushConf.Stat.Engine {
case "memory": case "memory":
initApp() StatStorage = memory.New()
case "redis": // case "redis":
initRedis() // initRedis()
case "boltdb": // case "boltdb":
initBoltDB() // initBoltDB()
default: default:
initApp() StatStorage = memory.New()
} }
}
func getRedisInt64Result(key string, count *int64) {
val, _ := RedisClient.Get(key).Result()
*count, _ = strconv.ParseInt(val, 10, 64)
}
func boltdbSet(key string, count int64) {
db, _ := storm.Open(PushConf.Stat.BoltDB.Path)
db.Set(PushConf.Stat.BoltDB.Bucket, key, count)
defer db.Close()
}
func boltdbGet(key string, count *int64) {
db, _ := storm.Open(PushConf.Stat.BoltDB.Path)
db.Get(PushConf.Stat.BoltDB.Bucket, key, count)
defer db.Close()
}
func addTotalCount(count int64) {
switch PushConf.Stat.Engine {
case "memory":
atomic.AddInt64(&RushStatus.TotalCount, count)
case "redis":
RedisClient.Set(TotalCountKey, strconv.Itoa(int(count)), 0)
case "boltdb":
boltdbSet(TotalCountKey, count)
default:
atomic.AddInt64(&RushStatus.TotalCount, count)
}
}
func addIosSuccess(count int64) {
switch PushConf.Stat.Engine {
case "memory":
atomic.AddInt64(&RushStatus.Ios.PushSuccess, count)
case "redis":
RedisClient.Set(IosSuccessKey, strconv.Itoa(int(count)), 0)
case "boltdb":
boltdbSet(IosSuccessKey, count)
default:
atomic.AddInt64(&RushStatus.Ios.PushSuccess, count)
}
}
func addIosError(count int64) {
switch PushConf.Stat.Engine {
case "memory":
atomic.AddInt64(&RushStatus.Ios.PushError, count)
case "redis":
RedisClient.Set(IosErrorKey, strconv.Itoa(int(count)), 0)
case "boltdb":
boltdbSet(IosErrorKey, count)
default:
atomic.AddInt64(&RushStatus.Ios.PushError, count)
}
}
func addAndroidSuccess(count int64) {
switch PushConf.Stat.Engine {
case "memory":
atomic.AddInt64(&RushStatus.Android.PushSuccess, count)
case "redis":
RedisClient.Set(AndroidSuccessKey, strconv.Itoa(int(count)), 0)
case "boltdb":
boltdbSet(AndroidSuccessKey, count)
default:
atomic.AddInt64(&RushStatus.Android.PushSuccess, count)
}
}
func addAndroidError(count int64) {
switch PushConf.Stat.Engine {
case "memory":
atomic.AddInt64(&RushStatus.Android.PushError, count)
case "redis":
RedisClient.Set(AndroidErrorKey, strconv.Itoa(int(count)), 0)
case "boltdb":
boltdbSet(AndroidErrorKey, count)
default:
atomic.AddInt64(&RushStatus.Android.PushError, count)
}
}
func getTotalCount() int64 {
var count int64
switch PushConf.Stat.Engine {
case "memory":
count = atomic.LoadInt64(&RushStatus.TotalCount)
case "redis":
getRedisInt64Result(TotalCountKey, &count)
case "boltdb":
boltdbGet(TotalCountKey, &count)
default:
count = atomic.LoadInt64(&RushStatus.TotalCount)
}
return count
}
func getIosSuccess() int64 {
var count int64
switch PushConf.Stat.Engine {
case "memory":
count = atomic.LoadInt64(&RushStatus.Ios.PushSuccess)
case "redis":
getRedisInt64Result(IosSuccessKey, &count)
case "boltdb":
boltdbGet(IosSuccessKey, &count)
default:
count = atomic.LoadInt64(&RushStatus.Ios.PushSuccess)
}
return count
}
func getIosError() int64 {
var count int64
switch PushConf.Stat.Engine {
case "memory":
count = atomic.LoadInt64(&RushStatus.Ios.PushError)
case "redis":
getRedisInt64Result(IosErrorKey, &count)
case "boltdb":
boltdbGet(IosErrorKey, &count)
default:
count = atomic.LoadInt64(&RushStatus.Ios.PushError)
}
return count
}
func getAndroidSuccess() int64 {
var count int64
switch PushConf.Stat.Engine {
case "memory":
count = atomic.LoadInt64(&RushStatus.Android.PushSuccess)
case "redis":
getRedisInt64Result(AndroidSuccessKey, &count)
case "boltdb":
boltdbGet(AndroidSuccessKey, &count)
default:
count = atomic.LoadInt64(&RushStatus.Android.PushSuccess)
}
return count
}
func getAndroidError() int64 {
var count int64
switch PushConf.Stat.Engine {
case "memory":
count = atomic.LoadInt64(&RushStatus.Android.PushError)
case "redis":
getRedisInt64Result(AndroidErrorKey, &count)
case "boltdb":
boltdbGet(AndroidErrorKey, &count)
default:
count = atomic.LoadInt64(&RushStatus.Android.PushError)
}
return count
} }
func appStatusHandler(c *gin.Context) { func appStatusHandler(c *gin.Context) {
@ -253,11 +46,11 @@ func appStatusHandler(c *gin.Context) {
result.QueueMax = cap(QueueNotification) result.QueueMax = cap(QueueNotification)
result.QueueUsage = len(QueueNotification) result.QueueUsage = len(QueueNotification)
result.TotalCount = getTotalCount() result.TotalCount = StatStorage.GetTotalCount()
result.Ios.PushSuccess = getIosSuccess() result.Ios.PushSuccess = StatStorage.GetIosSuccess()
result.Ios.PushError = getIosError() result.Ios.PushError = StatStorage.GetIosError()
result.Android.PushSuccess = getAndroidSuccess() result.Android.PushSuccess = StatStorage.GetAndroidSuccess()
result.Android.PushError = getAndroidError() result.Android.PushError = StatStorage.GetAndroidError()
c.JSON(http.StatusOK, result) c.JSON(http.StatusOK, result)
} }

View File

@ -2,137 +2,160 @@ package gorush
import ( import (
"github.com/stretchr/testify/assert" "github.com/stretchr/testify/assert"
"sync/atomic" // "sync/atomic"
"testing" "testing"
) )
func TestAddTotalCount(t *testing.T) { // func TestAddTotalCount(t *testing.T) {
InitAppStatus() // InitAppStatus()
addTotalCount(1000) // addTotalCount(1000)
val := atomic.LoadInt64(&RushStatus.TotalCount) // val := atomic.LoadInt64(&RushStatus.TotalCount)
assert.Equal(t, int64(1000), val) // assert.Equal(t, int64(1000), val)
} // }
func TestAddIosSuccess(t *testing.T) { // func TestAddIosSuccess(t *testing.T) {
InitAppStatus() // InitAppStatus()
addIosSuccess(1000) // addIosSuccess(1000)
val := atomic.LoadInt64(&RushStatus.Ios.PushSuccess) // val := atomic.LoadInt64(&RushStatus.Ios.PushSuccess)
assert.Equal(t, int64(1000), val) // assert.Equal(t, int64(1000), val)
} // }
func TestAddIosError(t *testing.T) { // func TestAddIosError(t *testing.T) {
InitAppStatus() // InitAppStatus()
addIosError(1000) // addIosError(1000)
val := atomic.LoadInt64(&RushStatus.Ios.PushError) // val := atomic.LoadInt64(&RushStatus.Ios.PushError)
assert.Equal(t, int64(1000), val) // assert.Equal(t, int64(1000), val)
} // }
func TestAndroidSuccess(t *testing.T) { // func TestAndroidSuccess(t *testing.T) {
InitAppStatus() // InitAppStatus()
addAndroidSuccess(1000) // addAndroidSuccess(1000)
val := atomic.LoadInt64(&RushStatus.Android.PushSuccess) // val := atomic.LoadInt64(&RushStatus.Android.PushSuccess)
assert.Equal(t, int64(1000), val) // assert.Equal(t, int64(1000), val)
} // }
func TestAddAndroidError(t *testing.T) { // func TestAddAndroidError(t *testing.T) {
InitAppStatus() // InitAppStatus()
addAndroidError(1000) // addAndroidError(1000)
val := atomic.LoadInt64(&RushStatus.Android.PushError) // val := atomic.LoadInt64(&RushStatus.Android.PushError)
assert.Equal(t, int64(1000), val) // assert.Equal(t, int64(1000), val)
} // }
func TestRedisServerSuccess(t *testing.T) { func TestStatForMemoryEngine(t *testing.T) {
PushConf.Stat.Redis.Addr = "localhost:6379"
err := initRedis()
assert.NoError(t, err)
}
func TestRedisServerError(t *testing.T) {
PushConf.Stat.Redis.Addr = "localhost:6370"
err := initRedis()
assert.Error(t, err)
}
func TestStatForRedisEngine(t *testing.T) {
var val int64 var val int64
PushConf.Stat.Engine = "redis" PushConf.Stat.Engine = "memory"
PushConf.Stat.Redis.Addr = "localhost:6379"
InitAppStatus() InitAppStatus()
addTotalCount(10) StatStorage.AddTotalCount(100)
addIosSuccess(20) StatStorage.AddIosSuccess(200)
addIosError(30) StatStorage.AddIosError(300)
addAndroidSuccess(40) StatStorage.AddAndroidSuccess(400)
addAndroidError(50) StatStorage.AddAndroidError(500)
val = getTotalCount() val = StatStorage.GetTotalCount()
assert.Equal(t, int64(10), val)
val = getIosSuccess()
assert.Equal(t, int64(20), val)
val = getIosError()
assert.Equal(t, int64(30), val)
val = getAndroidSuccess()
assert.Equal(t, int64(40), val)
val = getAndroidError()
assert.Equal(t, int64(50), val)
}
func TestDefaultEngine(t *testing.T) {
var val int64
PushConf.Stat.Engine = "test"
InitAppStatus()
addTotalCount(1)
addIosSuccess(2)
addIosError(3)
addAndroidSuccess(4)
addAndroidError(5)
val = getTotalCount()
assert.Equal(t, int64(1), val)
val = getIosSuccess()
assert.Equal(t, int64(2), val)
val = getIosError()
assert.Equal(t, int64(3), val)
val = getAndroidSuccess()
assert.Equal(t, int64(4), val)
val = getAndroidError()
assert.Equal(t, int64(5), val)
}
func TestStatForBoltDBEngine(t *testing.T) {
var val int64
PushConf.Stat.Engine = "boltdb"
InitAppStatus()
addTotalCount(100)
addIosSuccess(200)
addIosError(300)
addAndroidSuccess(400)
addAndroidError(500)
val = getTotalCount()
assert.Equal(t, int64(100), val) assert.Equal(t, int64(100), val)
val = getIosSuccess() val = StatStorage.GetIosSuccess()
assert.Equal(t, int64(200), val) assert.Equal(t, int64(200), val)
val = getIosError() val = StatStorage.GetIosError()
assert.Equal(t, int64(300), val) assert.Equal(t, int64(300), val)
val = getAndroidSuccess() val = StatStorage.GetAndroidSuccess()
assert.Equal(t, int64(400), val) assert.Equal(t, int64(400), val)
val = getAndroidError() val = StatStorage.GetAndroidError()
assert.Equal(t, int64(500), val) assert.Equal(t, int64(500), val)
} }
// func TestRedisServerSuccess(t *testing.T) {
// PushConf.Stat.Redis.Addr = "localhost:6379"
// err := initRedis()
// assert.NoError(t, err)
// }
// func TestRedisServerError(t *testing.T) {
// PushConf.Stat.Redis.Addr = "localhost:6370"
// err := initRedis()
// assert.Error(t, err)
// }
// func TestStatForRedisEngine(t *testing.T) {
// var val int64
// PushConf.Stat.Engine = "redis"
// PushConf.Stat.Redis.Addr = "localhost:6379"
// InitAppStatus()
// addTotalCount(10)
// addIosSuccess(20)
// addIosError(30)
// addAndroidSuccess(40)
// addAndroidError(50)
// val = getTotalCount()
// assert.Equal(t, int64(10), val)
// val = getIosSuccess()
// assert.Equal(t, int64(20), val)
// val = getIosError()
// assert.Equal(t, int64(30), val)
// val = getAndroidSuccess()
// assert.Equal(t, int64(40), val)
// val = getAndroidError()
// assert.Equal(t, int64(50), val)
// }
// func TestDefaultEngine(t *testing.T) {
// var val int64
// PushConf.Stat.Engine = "test"
// InitAppStatus()
// addTotalCount(1)
// addIosSuccess(2)
// addIosError(3)
// addAndroidSuccess(4)
// addAndroidError(5)
// val = getTotalCount()
// assert.Equal(t, int64(1), val)
// val = getIosSuccess()
// assert.Equal(t, int64(2), val)
// val = getIosError()
// assert.Equal(t, int64(3), val)
// val = getAndroidSuccess()
// assert.Equal(t, int64(4), val)
// val = getAndroidError()
// assert.Equal(t, int64(5), val)
// }
// func TestStatForBoltDBEngine(t *testing.T) {
// var val int64
// PushConf.Stat.Engine = "boltdb"
// InitAppStatus()
// addTotalCount(100)
// addIosSuccess(200)
// addIosError(300)
// addAndroidSuccess(400)
// addAndroidError(500)
// val = getTotalCount()
// assert.Equal(t, int64(100), val)
// val = getIosSuccess()
// assert.Equal(t, int64(200), val)
// val = getIosError()
// assert.Equal(t, int64(300), val)
// val = getAndroidSuccess()
// assert.Equal(t, int64(400), val)
// val = getAndroidError()
// assert.Equal(t, int64(500), val)
// }

View File

@ -2,14 +2,14 @@ package gorush
// Storage interface // Storage interface
type Storage interface { type Storage interface {
addTotalCount(int64) AddTotalCount(int64)
addIosSuccess(int64) AddIosSuccess(int64)
addIosError(int64) AddIosError(int64)
addAndroidSuccess(int64) AddAndroidSuccess(int64)
addAndroidError(int64) AddAndroidError(int64)
getTotalCount() int64 GetTotalCount() int64
getIosSuccess() int64 GetIosSuccess() int64
getIosError() int64 GetIosError() int64
getAndroidSuccess() int64 GetAndroidSuccess() int64
getAndroidError() int64 GetAndroidError() int64
} }

View File

@ -1,66 +1,84 @@
package memory package memory
import ( import (
"github.com/appleboy/gorush/gorush"
"sync/atomic" "sync/atomic"
) )
// StatusApp is app status structure
type statApp struct {
TotalCount int64 `json:"total_count"`
Ios IosStatus `json:"ios"`
Android AndroidStatus `json:"android"`
}
// AndroidStatus is android structure
type AndroidStatus struct {
PushSuccess int64 `json:"push_success"`
PushError int64 `json:"push_error"`
}
// IosStatus is iOS structure
type IosStatus struct {
PushSuccess int64 `json:"push_success"`
PushError int64 `json:"push_error"`
}
// Storage implements the storage interface for gorush (https://github.com/appleboy/gorush) // Storage implements the storage interface for gorush (https://github.com/appleboy/gorush)
func New(stat gorush.StatusApp) *Storage { func New() *Storage {
return &Storage{ return &Storage{
stat: stat, stat: &statApp{},
} }
} }
type Storage struct { type Storage struct {
stat gorush.StatusApp stat *statApp
} }
func (s *Storage) addTotalCount(count int64) { func (s *Storage) AddTotalCount(count int64) {
atomic.AddInt64(&s.stat.TotalCount, count) atomic.AddInt64(&s.stat.TotalCount, count)
} }
func (s *Storage) addIosSuccess(count int64) { func (s *Storage) AddIosSuccess(count int64) {
atomic.AddInt64(&s.stat.Ios.PushSuccess, count) atomic.AddInt64(&s.stat.Ios.PushSuccess, count)
} }
func (s *Storage) addIosError(count int64) { func (s *Storage) AddIosError(count int64) {
atomic.AddInt64(&s.stat.Ios.PushError, count) atomic.AddInt64(&s.stat.Ios.PushError, count)
} }
func (s *Storage) addAndroidSuccess(count int64) { func (s *Storage) AddAndroidSuccess(count int64) {
atomic.AddInt64(&s.stat.Android.PushSuccess, count) atomic.AddInt64(&s.stat.Android.PushSuccess, count)
} }
func (s *Storage) addAndroidError(count int64) { func (s *Storage) AddAndroidError(count int64) {
atomic.AddInt64(&s.stat.Android.PushError, count) atomic.AddInt64(&s.stat.Android.PushError, count)
} }
func (s *Storage) getTotalCount() int64 { func (s *Storage) GetTotalCount() int64 {
count := atomic.LoadInt64(&s.stat.TotalCount) count := atomic.LoadInt64(&s.stat.TotalCount)
return count return count
} }
func (s *Storage) getIosSuccess() int64 { func (s *Storage) GetIosSuccess() int64 {
count := atomic.LoadInt64(&s.stat.Ios.PushSuccess) count := atomic.LoadInt64(&s.stat.Ios.PushSuccess)
return count return count
} }
func (s *Storage) getIosError() int64 { func (s *Storage) GetIosError() int64 {
count := atomic.LoadInt64(&s.stat.Ios.PushError) count := atomic.LoadInt64(&s.stat.Ios.PushError)
return count return count
} }
func (s *Storage) getAndroidSuccess() int64 { func (s *Storage) GetAndroidSuccess() int64 {
count := atomic.LoadInt64(&s.stat.Android.PushSuccess) count := atomic.LoadInt64(&s.stat.Android.PushSuccess)
return count return count
} }
func (s *Storage) getAndroidError() int64 { func (s *Storage) GetAndroidError() int64 {
count := atomic.LoadInt64(&s.stat.Android.PushError) count := atomic.LoadInt64(&s.stat.Android.PushError)
return count return count

View File

@ -1,7 +1,6 @@
package memory package memory
import ( import (
"github.com/appleboy/gorush/gorush"
"github.com/stretchr/testify/assert" "github.com/stretchr/testify/assert"
"testing" "testing"
) )
@ -9,25 +8,25 @@ import (
func TestMemoryEngine(t *testing.T) { func TestMemoryEngine(t *testing.T) {
var val int64 var val int64
memory := New(gorush.StatusApp{}) memory := New()
memory.addTotalCount(1) memory.AddTotalCount(1)
val = memory.getTotalCount() val = memory.GetTotalCount()
assert.Equal(t, int64(1), val) assert.Equal(t, int64(1), val)
memory.addIosSuccess(2) memory.AddIosSuccess(2)
val = memory.getIosSuccess() val = memory.GetIosSuccess()
assert.Equal(t, int64(2), val) assert.Equal(t, int64(2), val)
memory.addIosError(3) memory.AddIosError(3)
val = memory.getIosError() val = memory.GetIosError()
assert.Equal(t, int64(3), val) assert.Equal(t, int64(3), val)
memory.addAndroidSuccess(4) memory.AddAndroidSuccess(4)
val = memory.getAndroidSuccess() val = memory.GetAndroidSuccess()
assert.Equal(t, int64(4), val) assert.Equal(t, int64(4), val)
memory.addAndroidError(5) memory.AddAndroidError(5)
val = memory.getAndroidError() val = memory.GetAndroidError()
assert.Equal(t, int64(5), val) assert.Equal(t, int64(5), val)
} }