fix ad validation : remove schedule and waypoints duplication

This commit is contained in:
Sylvain Briat 2024-01-18 15:53:48 +01:00
parent 2009355b18
commit b039dbb3bd
3 changed files with 53 additions and 47 deletions

View File

@ -43,7 +43,8 @@ export class AdMapper
frequency: copy.frequency, frequency: copy.frequency,
fromDate: new Date(copy.fromDate), fromDate: new Date(copy.fromDate),
toDate: new Date(copy.toDate), toDate: new Date(copy.toDate),
schedule: { schedule: copy.schedule
? {
create: copy.schedule.map((scheduleItem: ScheduleItemProps) => ({ create: copy.schedule.map((scheduleItem: ScheduleItemProps) => ({
uuid: v4(), uuid: v4(),
day: scheduleItem.day as number, day: scheduleItem.day as number,
@ -58,11 +59,13 @@ export class AdMapper
createdAt: now, createdAt: now,
updatedAt: now, updatedAt: now,
})), })),
}, }
: undefined,
seatsProposed: copy.seatsProposed as number, seatsProposed: copy.seatsProposed as number,
seatsRequested: copy.seatsRequested as number, seatsRequested: copy.seatsRequested as number,
strict: copy.strict as boolean, strict: copy.strict as boolean,
waypoints: { waypoints: copy.waypoints
? {
create: copy.waypoints.map((waypoint: WaypointProps) => ({ create: copy.waypoints.map((waypoint: WaypointProps) => ({
uuid: v4(), uuid: v4(),
position: waypoint.position, position: waypoint.position,
@ -77,9 +80,8 @@ export class AdMapper
createdAt: now, createdAt: now,
updatedAt: now, updatedAt: now,
})), })),
}, }
createdAt: copy.createdAt, : undefined,
updatedAt: copy.updatedAt,
}; };
return record; return record;
}; };
@ -97,7 +99,7 @@ export class AdMapper
frequency: record.frequency as Frequency, frequency: record.frequency as Frequency,
fromDate: record.fromDate.toISOString().split('T')[0], fromDate: record.fromDate.toISOString().split('T')[0],
toDate: record.toDate.toISOString().split('T')[0], toDate: record.toDate.toISOString().split('T')[0],
schedule: record.schedule.map((scheduleItem: ScheduleItemModel) => ({ schedule: record.schedule?.map((scheduleItem: ScheduleItemModel) => ({
day: scheduleItem.day, day: scheduleItem.day,
time: `${scheduleItem.time time: `${scheduleItem.time
.getUTCHours() .getUTCHours()
@ -111,7 +113,7 @@ export class AdMapper
seatsProposed: record.seatsProposed, seatsProposed: record.seatsProposed,
seatsRequested: record.seatsRequested, seatsRequested: record.seatsRequested,
strict: record.strict, strict: record.strict,
waypoints: record.waypoints.map((waypoint: WaypointModel) => ({ waypoints: record.waypoints?.map((waypoint: WaypointModel) => ({
position: waypoint.position, position: waypoint.position,
address: { address: {
name: waypoint.name, name: waypoint.name,

View File

@ -24,22 +24,26 @@ export type AdBaseModel = {
seatsProposed: number; seatsProposed: number;
seatsRequested: number; seatsRequested: number;
strict: boolean; strict: boolean;
createdAt: Date;
updatedAt: Date;
}; };
export type AdReadModel = AdBaseModel & { export type AdReadModel = AdBaseModel & {
waypoints: WaypointModel[]; waypoints: WaypointModel[];
schedule: ScheduleItemModel[]; schedule: ScheduleItemModel[];
createdAt: Date;
updatedAt: Date;
}; };
export type AdWriteModel = AdBaseModel & { export type AdWriteModel = AdBaseModel & {
waypoints: { schedule: ScheduleWriteModel | undefined;
create: WaypointModel[]; waypoints: WaypointWriteModel | undefined;
}; };
schedule: {
export type ScheduleWriteModel = {
create: ScheduleItemModel[]; create: ScheduleItemModel[];
}; };
export type WaypointWriteModel = {
create: WaypointModel[];
}; };
export type ScheduleItemModel = { export type ScheduleItemModel = {

View File

@ -144,9 +144,9 @@ describe('Ad Mapper', () => {
it('should map domain entity to persistence data', async () => { it('should map domain entity to persistence data', async () => {
const mapped: AdWriteModel = adMapper.toPersistence(adEntity); const mapped: AdWriteModel = adMapper.toPersistence(adEntity);
expect(mapped.waypoints.create[0].uuid.length).toBe(36); expect(mapped.waypoints?.create[0].uuid.length).toBe(36);
expect(mapped.waypoints.create[1].uuid.length).toBe(36); expect(mapped.waypoints?.create[1].uuid.length).toBe(36);
expect(mapped.schedule.create.length).toBe(1); expect(mapped.schedule?.create.length).toBe(1);
}); });
it('should map persisted data to domain entity', async () => { it('should map persisted data to domain entity', async () => {