diff --git a/.gitlab/merge_request_templates/default.md b/.gitlab/merge_request_templates/default.md index 43eb09b..9bb12a7 100644 --- a/.gitlab/merge_request_templates/default.md +++ b/.gitlab/merge_request_templates/default.md @@ -1,6 +1,6 @@ _Replace italic text by your own description_ -## Merge Request description +## Feature Merge Request ### Why this Merge Request @@ -24,38 +24,32 @@ _Include any extra information or considerations for reviewers._ ### Merge Request -- [ ] Target branch identified. -- [ ] Code based on last version of target branch. -- [ ] Description filled. -- [ ] Impact on other project codebase identified. -- [ ] Documentation reflects the changes made. -- [ ] Test run in gitlab pipeline and locally. -- [ ] One or more reviewer is defined +- [ ] Target branch identified. +- [ ] Code based on last version of target branch. +- [ ] Description filled. +- [ ] Impact on other project codebase identified. +- [ ] Documentation reflects the changes made. +- [ ] Test run in gitlab pipeline and locally. +- [ ] One or more reviewer is defined ### Code Review -- [ ] Code follows project coding guidelines (todo: add a link to doc). -- [ ] Code follows project designed architecture (todo: add a link to doc). -- [ ] Code is easily readable. -- [ ] Everything new have an explicit and pertinent name (variable, method, file ...) -- [ ] No redundant/duplicate code (unless explain by architecture choice) -- [ ] Commit are all related to MR and well written (Atomic commit). -- [ ] New code is tested and covered by automated test. -- [ ] No useless logging or debugging code. -- [ ] No code can be replaced by library or framework code. - -### Change Management - -- [ ] Merge date is planned -- [ ] Concerned Team are aware of the change -- [ ] No other change on the same day (if possible) +- [ ] Code follows project coding guidelines. +- [ ] Code follows project designed architecture. +- [ ] Code is easily readable. +- [ ] Everything new have an explicit and pertinent name (variable, method, file ...) +- [ ] No redundant/duplicate code (unless explain by architecture choice) +- [ ] Commit are all related to MR and well written (Atomic commit). +- [ ] New code is tested and covered by automated test. +- [ ] No useless logging or debugging code. +- [ ] No code can be replaced by library or framework code. ### TODO before merge -- [ ] **add any task here** -- [ ] ... +- [ ] _add any task here_ +- [ ] ... ### TODO after merge -- [ ] **add any task here** -- [ ] ... +- [ ] _add any task here_ +- [ ] ... diff --git a/.gitlab/merge_request_templates/release.md b/.gitlab/merge_request_templates/release.md new file mode 100644 index 0000000..941915e --- /dev/null +++ b/.gitlab/merge_request_templates/release.md @@ -0,0 +1,62 @@ +_Replace italic text by your own description_ + +## Release Merge Request + +### Why this Merge Request + +_This merge request addresses, and describe the problem or user story being addressed._ + +### What is implemented, what is the chosen solution + +_Explain the fix or solution implemented. Which other solution have been envisaged._ + +### Related issues and impact on other project in codebase + +_Provide links to the related issues, feature requests and merge request (from Gitlab and Redmine)._ + +_And Link to other project Impacted._ + +### Other Information + +_Include any extra information or considerations for reviewers._ + +## Checklists + +### Merge Request + +- [ ] Target branch identified. +- [ ] Code based on last version of target branch. +- [ ] Description filled. +- [ ] Impact on other project codebase identified. +- [ ] Documentation reflects the changes made. +- [ ] Test run in gitlab pipeline and locally. +- [ ] One or more reviewer is defined + +### Code Review + +- [ ] Code follows project coding guidelines. +- [ ] Code follows project designed architecture. +- [ ] Code is easily readable. +- [ ] Everything new have an explicit and pertinent name (variable, method, file ...) +- [ ] No redundant/duplicate code (unless explain by architecture choice) +- [ ] Commit are all related to MR and well written (Atomic commit). +- [ ] New code is tested and covered by automated test. +- [ ] No useless logging or debugging code. +- [ ] No code can be replaced by library or framework code. + +### Change Management + +- [ ] Release is planned +- [ ] Merge Request to be included are identified +- [ ] Concerned Team are aware of the change +- [ ] No other change on the same day (if possible) + +### TODO before merge + +- [ ] _add any task here_ +- [ ] ... + +### TODO after merge + +- [ ] _add any task here_ +- [ ] ... diff --git a/.gitlab/merge_request_templates/smallfix.md b/.gitlab/merge_request_templates/smallfix.md new file mode 100644 index 0000000..1bfb9e3 --- /dev/null +++ b/.gitlab/merge_request_templates/smallfix.md @@ -0,0 +1,37 @@ +_Replace italic text by your own description_ + +## Small Fix Merge Request + +### Why this Merge Request + +_This merge request addresses, and describe the problem or user story being addressed._ + +### What is implemented, what is the chosen solution + +_Explain the fix or solution implemented. Which other solution have been envisaged._ + +### Related issues and impact on other project in codebase + +_Provide links to the related issues, feature requests and merge request (from Gitlab and Redmine)._ + +_And Link to other project Impacted._ + +### Other Information + +_Include any extra information or considerations for reviewers._ + +## Checklists + +### Merge Request + +- [ ] Target branch identified. +- [ ] Code based on last version of target branch. +- [ ] Description filled. +- [ ] Impact on other project codebase identified. +- [ ] Test run in gitlab pipeline and locally. + +### Code Review + +- [ ] Code is easily readable. +- [ ] Commit are all related to MR and well written (Atomic commit). +- [ ] No useless logging or debugging code. diff --git a/.prettierignore b/.prettierignore index 192c132..9c99b59 100644 --- a/.prettierignore +++ b/.prettierignore @@ -4,3 +4,4 @@ node_modules dist coverage .prettierrc.json +.gitlab