From 3786fcc2c2d0c1237c0cdd038b90281a1ab6fe42 Mon Sep 17 00:00:00 2001 From: Sylvain Briat Date: Thu, 28 Mar 2024 17:48:20 +0100 Subject: [PATCH] improve TODO explanation in journey value object --- .../ad/core/domain/value-objects/journey.value-object.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/modules/ad/core/domain/value-objects/journey.value-object.ts b/src/modules/ad/core/domain/value-objects/journey.value-object.ts index 90ca3ff..e637ed5 100644 --- a/src/modules/ad/core/domain/value-objects/journey.value-object.ts +++ b/src/modules/ad/core/domain/value-objects/journey.value-object.ts @@ -46,6 +46,12 @@ export class Journey extends ValueObject { const driverActorTime = passengerDepartureJourneyItem.actorTimes.find( (actorTime: ActorTime) => actorTime.role == Role.DRIVER, ) as ActorTime; + // TODO : check if the following conditions are even to the ones used in the return + // 4 possibilities to be valid : + // - 1 : the driver time boundaries are within the passenger time boundaries + // - 2 : the max driver time boundary is within the passenger time boundaries + // - 3 : the min driver time boundary is within the passenger time boundaries + // - 4 : the passenger time boundaries are within the driver time boundaries // return ( // // 1 // (driverActorTime.firstMinDatetime >=