ncaron
/
matcher
mirror of https://gitlab.com/mobicoop/v3/service/matcher.git
1
0
Fork 1
Code Issues Packages Projects Releases Wiki Activity

improve TODO explanation in journey value object

This commit is contained in:
Sylvain Briat 2024-03-28 17:48:20 +01:00 committed by sbriat
parent e53c12ba74
commit 3786fcc2c2
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/modules/ad/core/domain/value-objects/journey.value-object.ts
View File

@ -46,6 +46,12 @@ export class Journey extends ValueObject<JourneyProps> {
const driverActorTime = passengerDepartureJourneyItem.actorTimes.find( const driverActorTime = passengerDepartureJourneyItem.actorTimes.find(
(actorTime: ActorTime) => actorTime.role == Role.DRIVER, (actorTime: ActorTime) => actorTime.role == Role.DRIVER,
) as ActorTime; ) as ActorTime;
// TODO : check if the following conditions are even to the ones used in the return
// 4 possibilities to be valid :
// - 1 : the driver time boundaries are within the passenger time boundaries
// - 2 : the max driver time boundary is within the passenger time boundaries
// - 3 : the min driver time boundary is within the passenger time boundaries
// - 4 : the passenger time boundaries are within the driver time boundaries
// return ( // return (
// // 1 // // 1
// (driverActorTime.firstMinDatetime >= // (driverActorTime.firstMinDatetime >=