1.6 KiB
1.6 KiB
Replace italic text by your own description
Feature Merge Request
Why this Merge Request
This merge request addresses, and describe the problem or user story being addressed.
What is implemented, what is the chosen solution
Explain the fix or solution implemented. Which other solution have been envisaged.
Related issues and impact on other project in codebase
Provide links to the related issues, feature requests and merge request (from Gitlab and Redmine).
And Link to other project Impacted.
Other Information
Include any extra information or considerations for reviewers.
Checklists
Merge Request
- Target branch identified.
- Code based on last version of target branch.
- Description filled.
- Impact on other project codebase identified.
- Documentation reflects the changes made.
- Test run in gitlab pipeline and locally.
- One or more reviewer is defined
Code Review
- Code follows project coding guidelines.
- Code follows project designed architecture.
- Code is easily readable.
- Everything new have an explicit and pertinent name (variable, method, file ...)
- No redundant/duplicate code (unless explain by architecture choice)
- Commit are all related to MR and well written (Atomic commit).
- New code is tested and covered by automated test.
- No useless logging or debugging code.
- No code can be replaced by library or framework code.
TODO before merge
- add any task here
- ...
TODO after merge
- add any task here
- ...